Auto issue close action and updated issue templates

haugene / vpn-configs-contrib

A collection of configs for various VPN providers

GNU General Public License v3.0

188 stars 753 forks source link

Auto issue close action and updated issue templates #5

Closed pkishino closed 3 years ago

pkishino commented 3 years ago

Breaking change

<placeholder>

Proposed change

This will allow a github action to close issues automatically like in the main repo,  as well as updated issue templates

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New provider (thank you!)
[ ] Updated provider (thank you!)
[x] New feature (which adds functionality to a provider script/repo usage)
[ ] Breaking change (fix/feature causing existing functionality to break)

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue: relates to #
Link to documentation updated (if done separately): https://...

Checklist

[x] The code change is tested and works locally.
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated

haugene commented 3 years ago

Have not seen this one, sorry. But great to have it in place :+1: I think we need to re-visit the bug report template in this repo though. It's very geared towards the main image.

Not sure what a bug would look like here? Configs that are valid which is not playing well with the image? New options that our scripts mess up somehow? Most of it kind of feels like the main project's problem. I'm actually hoping that the configs here can be a straight dump from the providers. Not even the auth-user-pass /config/...credentials fix. That should be handled by the "modify config" script in the main project I think. It's a thought at least.

pkishino commented 3 years ago

Yeah, fair enough.. can easily just “hide” it in the config.yml

On Tue, Mar 30, 2021 at 8:39 Kristian Haugene @.***> wrote:

Have not seen this one, sorry. But great to have it in place 👍 I think we need to re-visit the bug report template in this repo though. It's very geared towards the main image.

Not sure what a bug would look like here? Configs that are valid which is not playing well with the image? New options that our scripts mess up somehow? Most of it kind of feels like the main project's problem. I'm actually hoping that the configs here can be a straight dump from the providers. Not even the auth-user-pass /config/...credentials fix. That should be handled by the "modify config" script in the main project I think. It's a thought at least.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/haugene/vpn-configs-contrib/pull/5#issuecomment-809796040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7OFYSAHR3QXR7XX2XZS4TTGEMVHANCNFSM4ZN2M4QQ .