search

hauke96 / GeoNotes

A simple app to create georeferences notes.
GNU General Public License v3.0
58 stars 10 forks source link

Text box too high #36

Closed opk12 closed 3 years ago

opk12 commented 3 years ago

The text box is high 6 lines, so the first 3 lines are not visible (are beyond the map's upper border) and typing seems not to have effect. To see what you typed, drag the map while the note is selected.

This is on a Samsung Galaxy J5 with Android 7.

hauke96 commented 3 years ago

Unfortunately it's not really possible to dynamically set the input size in respect tot the screen size or something like that, because it's a popup and the keyboard comes up etc.

For the person fixing this: I think reducing the amount of lines to two would do the trick. Even better would be a settings entry to manually change the number of line for people wanting to have more or less lines.

opk12 commented 3 years ago

What about a border around the note's balloon, or another visual indication that the balloon extends beyond what you see? Before discovering this map scrolling "secret trick" by chance, I did believe the text box has white-on-white characters (as in the totally unrelated #35) and height of a couple of lines; and note editing was hard (the default Samsung keyboard lacks left/right arrows).

hauke96 commented 3 years ago

The problem is, that the popup/balloon is embedded within the map, so that it moves with the map (which I wouldn't change). Positioning and dynamic resizing is therefore a bit tricky.

Maybe it's possible to define some sort of border/margin around the popup and let android resize it according to the available space, but my knowledge about that is very limited so I can't promise anything so far.

opk12 commented 3 years ago

Is the popup generated by a library? If so, where can I find its issue tracker to do a quick search for an already known issue?

opk12 commented 3 years ago

For example, OSMBugs has round corners and a couple pixel border. The round corners make it apparent that the popup upper edge is not at the right-angled popup border's intersection with the app titlebar.

screenshot

hauke96 commented 3 years ago

OSMBugs and GeoNotes both use OsmDroid and both are following the basic strategy: inherit from InfoWindow, an abstract class from OsmDroid, and add our own Android-Fragment and logic to it. My own window class is called MarkerWindow and can be found here.

Feel free to raise an issue at OsmDroid. However I just tried a few things and I think this is not a trivial or even common problem at all.

hauke96 commented 3 years ago

I changed the behavior in 1.4.1 to the following: The upper edge of the popup is not always just below the upper edge of the map. Hopefully this should fix the issue that the popup is not completely visible. The input field is also smaller now and becomes larger when I e.g. add a line break.

I close this issue because the behavior is now fixed. But feel free to re-open it if there's still any problem. The new 1.4.1 version will available in a few days via F-Droid.