search

hauntsaninja / mypy_primer

Run mypy and pyright over millions of lines of code
MIT License
55 stars 29 forks source link

Primer is hanging in typeshed's CI #112

Open AlexWaygood opened 7 months ago

AlexWaygood commented 7 months ago

See e.g. https://github.com/python/typeshed/pull/11078

The issue is with a project in shard 0. I cancelled the shard after 25 minutes on the first run, and then re-ran it. I cancelled it after 15 minutes on the rerun.

AlexWaygood commented 7 months ago

The problematic project is zetta_utils. primer tries to run git clone --recurse-submodules https://github.com/ZettaAI/zetta_utils --depth 1. But if you run that currently, here's what happens:

>git clone --recurse-submodules https://github.com/ZettaAI/zetta_utils --depth 1
Cloning into 'zetta_utils'...
remote: Enumerating objects: 1212, done.
remote: Counting objects: 100% (1212/1212), done.
remote: Compressing objects: 100% (873/873), done.
remote: Total 1212 (delta 430), reused 830 (delta 291), pack-reused 0
Receiving objects: 100% (1212/1212), 574.33 KiB | 2.92 MiB/s, done.
Resolving deltas: 100% (430/430), done.
error: invalid path 'specs/sergiy/inference/cns/2_med/v3/9_old/\'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

I verified in https://github.com/AlexWaygood/typeshed/pull/24 that primer works again if zetta_utils is excluded.

AlexWaygood commented 7 months ago

Looks like they might have added some "private submodules" or something, meaning that --recurse-submodules doesn't work for that repo anymore unless you're a member of the Zetta-AI team?? See https://github.com/ZettaAI/zetta_utils/commit/9dd6a870a031568dbe278bf073cc4fc0deb62ae5

AlexWaygood commented 7 months ago

Should the project just be deleted from projects.py? Commented out for now? Should we change the way we try to clone the projects to avoid --recurse-submodules for some or all projects?

I await the opinions of mypy_primer maintainers :)

hauntsaninja commented 7 months ago

Thanks for investigating! I just removed it for now in https://github.com/hauntsaninja/mypy_primer/commit/d1263e0c5f4552c13c0449b62ba0dc8e4167a0bd , can figure out if we should change clone or something later

AlexWaygood commented 7 months ago

Thanks very much!