move porcupine out of failures expected section

hauntsaninja / mypy_primer

Run mypy and pyright over millions of lines of code

MIT License

57 stars 30 forks source link

move porcupine out of failures expected section #13

Closed Akuli closed 3 years ago

Akuli commented 3 years ago

Porcupine no longer bundles a custom typeshed in a git submodule.

Akuli commented 3 years ago

The CI was so quick that I don't think it actually checked much. Can this break something unexpectedly?

Akuli commented 3 years ago

Nevermind. It really shouldn't break anything, since the success/failure expected sections are separated only by a comment :)

Akuli commented 3 years ago

...except they are not, because I forgot to add expected_success=True :D

hauntsaninja commented 3 years ago

Thanks! CI currently only runs lint. I'm lazy / it's slow / wasn't sure that there'd be much value in running mypy primer itself here / I'm hands on enough with typeshed that if things got catastrophically broken I'd notice and fix.