search

hauntsaninja / mypy_primer

Run mypy and pyright over millions of lines of code
MIT License
55 stars 29 forks source link

Print truncated in number of lines, not chars? #36

Closed ethanhs closed 2 years ago

ethanhs commented 2 years ago

Looking at https://github.com/python/mypy/pull/12901 it occurs to me since our errors are more line-oriented, it may make more sense to print the number of lines truncated instead of number of characters.

For example, in that PR, it tells me nothing that there are 3M truncated characters (well, other than there are a lot more errors) but number of lines would give a better approximate number of errors reported.

hauntsaninja commented 2 years ago

Good point, fixed in https://github.com/python/mypy/pull/12910 and https://github.com/python/typeshed/pull/7993

ethanhs commented 2 years ago

Thanks!