Closed sirosen closed 1 year ago
sirosen
commented
2 years ago Oh, I forgot to mention my motivation: I plan to be doing a bunch of work on types-jsonschema over the coming year, and want mypy_primer to have a couple more projects which use those stubs, so that the chances of introducing bugs are lower. cloud-init seems to me like a really good candidate.
hauntsaninja
commented
2 years ago Nope, no obligation for anyone else!
I'd also be willing to add https://github.com/matrix-org/synapse even without the plugin, as long as type checking it does something reasonable without the plugin.
holmanb
commented
2 years ago @sirosen Hi there! Thanks for the ping.
No objections, sounds good to me!
A couple of notes, in case it helps:
sirosen
commented
1 year ago I'd also be willing to add https://github.com/matrix-org/synapse even without the plugin, as long as type checking it does something reasonable without the plugin.
I'm happy to circle back on this at some later date... but I'm also okay not worrying about it.
I'm still casually looking at https://github.com/search?q=types-jsonschema&type=code to see if I can find anyone else who should be included for my (selfish!) purposes. Suggestions of other ways of finding prominent typeshed users very much welcome. 😄
Any objection to merging this as it currently stands? It seems like we're all happy to add cloud-init to mypy_primer!
holmanb
commented
1 year ago @sirosen No objections for cloud-init folks!
The mypy invocation is taken from their tox config, as is the list of typeshed stubs to use.
cc @holmanb , this might interest you as I see you're the @canonical team member who most recently made changes to the mypy config for
cloud-init. Being in mypy_primer doesn't carry any obligation for you, but it means your project will be used to examine typeshed and mypy changes to assess the impact. At least, I don't think there's any obligation -- someone please correct me if I'm wrong!