search

hauntsaninja / mypy_primer

Run mypy and pyright over millions of lines of code
MIT License
55 stars 29 forks source link

Shard projects more evenly #60

Closed hauntsaninja closed 1 year ago

hauntsaninja commented 1 year ago

Fixes #58

hauntsaninja commented 1 year ago

cc @A5rocks

A5rocks commented 1 year ago

Looks good -- assuming the code for distributing into buckets works as expected 😅

hauntsaninja commented 1 year ago

It looks like it works, but my first attempt didn't, in a somewhat interesting way.

Originally I had shard_projects= [[]] * ARGS.num_shards) instead of shard_projects = [[] for _ in range(ARGS.num_shards)]. In the first you end up with multiple references to the same list