search

hauntsaninja / mypy_primer

Run mypy and pyright over millions of lines of code
MIT License
55 stars 29 forks source link

Add `pwndbg` #72

Closed AlexWaygood closed 1 year ago

AlexWaygood commented 1 year ago

This gets us some coverage for our types-gdb stubs in typeshed. The project is currently working towards getting type-checking errors down to zero, and may be submitting more typeshed PRs for our gdb stubs in the future: https://github.com/pwndbg/pwndbg/issues/1475.

There are lots of other dependencies installed if you run pip install dev-requirements.txt in a virtual environment inside the pwndbg repo, but types-gdb seems to be the only one that's relevant to type-checking.

hauntsaninja commented 1 year ago

Thanks! The quality of type hints in this repo is very poor, though. E.g. there's a bunch of error: Name "List" is not defined [name-defined]

gsingh93 commented 1 year ago

Thanks! The quality of type hints in this repo is very poor, though. E.g. there's a bunch of error: Name \"List\" is not defined [name-defined]

We're working on it! We started recently from a completely untyped codebase that does some things that are hard to type check without some refactoring, so it'll take some time.