search

hauntsaninja / mypy_primer

Run mypy and pyright over millions of lines of code
MIT License
55 stars 29 forks source link

update cwltool/schema-salad setup to be more resiliant #90

Closed mr-c closed 7 months ago

mr-c commented 1 year ago

expected_mypy_success=True as well

mr-c commented 1 year ago

Tested locally with mypy_primer -k common-workflow-language

mr-c commented 7 months ago

This is ready for review and merging, thanks!

A5rocks commented 7 months ago

I'm not sure grep here is allowed because mypy-primer should (though it's kinda bad at it) be able to run on Windows.

... though tbh I was looking at making mypy-primer run on Windows and ended up having to exclude projects so a only_platform kwarg might work well...

mr-c commented 7 months ago

I'm not sure grep here is allowed because mypy-primer should (though it's kinda bad at it) be able to run on Windows.

... though tbh I was looking at making mypy-primer run on Windows and ended up having to exclude projects so a only_platform kwarg might work well...

Then cwltool and schema-salad should be excluded from MS Windows anyhow, as they explicitly don't support that platform 😊

So, I'd like the keep the grep.

mr-c commented 7 months ago

@hauntsaninja Done, thank you!