search

haushinka2dx / atmosphere-web

1 stars 2 forks source link

Uploadable #53

Closed haushinka2dx closed 10 years ago

haushinka2dx commented 10 years ago

Overview

Enabled to upload everything, download everyting, preview images on timeline, view full images.

You can test on staging environment

https://atmos.interprism.co.jp/atmos-web-stg/ id/pass -> bob/BOB

Screenshots

Attachment files on timeline

attachment-timeline

View Fullsize Image

attachment-image

Download non-image file by clicking icons on timeline

attachment-download

Message Sender Panel with Upload Zone

attachment-sender-initial

Drag and Dropped image file

attachment-sender-image

Drag and Dropped non-image file

attachment-sender-zip

Limitations

  1. Max file size is 100MB
  2. Upload was executed immediately when you drop file to Message Panel's zone
  3. Also, upload can not be canceled
  4. Uploaded files are PUBLIC. (server API's limitation)
  5. Uploaded files can not be removed by user (server API's limitation)

    Remarks

    • fixed #14 by this PR
haushinka2dx commented 10 years ago

ドヤ :smile: @kannokanno @y-motegi @ip-s-pra @Imamotty

haushinka2dx commented 10 years ago

コードざっくりとしか自己レビューしてないです。（もう疲れた） しょぼい指摘ばっかりかもしれませんが、レビューお願いします。

あとこのへんのライブラリ使いました。

kannokanno commented 10 years ago

+1

kannokanno commented 10 years ago

夜か、明日みまっす

haushinka2dx commented 10 years ago

どもです！全然マストじゃないので〜。ゆっくりで〜。

kannokanno commented 10 years ago

LGTM

kannokanno commented 10 years ago

デブサミで覚えてきたLGTMを使ってみた。 (LGTM = Looks good to me = 私はいいと思うよ的な)

haushinka2dx commented 10 years ago

マジすか。信じられん。

kannokanno commented 10 years ago

やっていることは

しかしていないので、特にまずそうなところはないのではって感じでした

kannokanno commented 10 years ago

D&Dやタイムライン上の表示はライブラリに委譲していますし

haushinka2dx commented 10 years ago

まあ確かに…。じゃあマージしちゃいます