search

haussli / draft-dahm-opsawg-tacacs-security

IETF draft for new tacacs+ security features
1 stars 1 forks source link

'-' or '_' in AVP names? #15

Closed haussli closed 3 years ago

haussli commented 3 years ago

I mixed the new '-' or '_' in AVP names. ssh_pubkey_type, ssh_pubkey, ssh-subsystem. Does this matter? Douglas told me once of the common practice, but I have forgotten. IIRC, ssh-subsystem with the '-' came from the SSH RFCs.

td-tacacs commented 3 years ago

I would aim to be consistent troughout the document. FWIW, my preference would be to use '_'

dcmgashcisco commented 3 years ago

I also vote for _, it is by far the most used in the old RFC.

hassiosni commented 3 years ago

I think this is where Douglas' comment from #12 belongs: "I guess the challenge is, this will mean that the ssh_pubkey_type is no longer exactly the same as in the SSH RFCs?"

It might be only ssh-subsystem that is defined in the RFCs. We would need to research this.

haussli commented 3 years ago

I thought that I had chosen '-' in ssh-subsystem specifically to match a spec/rfc, but I can not it. Made the replacement in bdef7d4359.