search

hautel / CommitAnalizer

0 stars 0 forks source link

Remove useless lines in commit message #13

Open hautel opened 6 years ago

hautel commented 6 years ago

Remove lines starting with "Closes http" , "fbshipit-source-id", "Pulled By", "Differential Revision", "Reviewed By" as they occur in multiple commit messages and they are not giving any important information

Examples: Make getCurrentActivity public on ReactContext Summary: Addresses #8661 Closes https://github.com/facebook/react-native/pull/9071 Differential Revision: D3641285 Pulled By: foghina fbshipit-source-id: dede86743efddc33b6ead053e805770fc213685c

Execute init task on thread pool executor Reviewed By: foghina Differential Revision: D3522112 fbshipit-source-id: 8a0880d0e7bf3e0bce02c44e8d504f01ab47beb8

hautel commented 6 years ago

fb-gh-sync-id or generally removing lines with tokens matching a regex for the id?

Prevent ReactMarker class from being stripped in release Differential Revision: D2547100 fb-gh-sync-id: c6a5d2f70bfdf5fa6fdd7f17f063de7ad837ece3

hautel commented 6 years ago

Remove a stray 'the'.

Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=133962640

Minor FindBugs bugfix: not caching entrySet as intended. Revision created by MOE tool push_codebase. MOE_MIGRATION=2742 git-svn-id: https://guava-libraries.googlecode.com/svn/trunk@564 8138a162-5c33-11de-8abc-d1c337b90d21

hautel commented 6 years ago

Fixes bug in PATCH method. Sets the method before setting the body. Just look at PUT and POST methods some lines above. The method is set before calling to addBodyIfExists(). The method should be set before adding the body. Otherwise, some libraries will try to establish a connection with the wrong method (GET by default). Change-Id: I993a62cdc5cbccbf54f9bae4f6b183e2edf4304d

hautel commented 6 years ago

Fix handling of Wrapper HTTP Basic Auth on Java 5 IOException does not have a (String, Exception) CTOR on Java 5. Use RuntimeException instead. +review REVIEW-6222

hautel commented 6 years ago

Updating version string to 3.0 Summary: See title Test Plan: - test pass Reviewers: clang, mingfli Reviewed By: clang CC: msdkexp@ Differential Revision: https://phabricator.fb.com/D657738

hautel commented 6 years ago

Fixed null pointer issue. Summary: We need to call unbindService on a Context. In some cases, mAuthActivity is null. Since applicationsContext is passed in to the constructor and never modified, it should not be null. So we call unbindService on applicationsContext instead. Test Plan: Try SSO with pre-1.8 FB app. Reviewers: vijaye, jacl, caabernathy Reviewed By: vijaye CC: selekman, constantin, lshepard Differential Revision: https://phabricator.fb.com/D432892 Revert Plan: Safe to revert Task ID: 982981

hautel commented 6 years ago

git-subtree-dir: guice git-subtree-split: 4bd04c70c001041491b333a3b8a61da9e9264cb6

hautel commented 6 years ago

HOTFIX: fix KafkaStreams SmokeTest Set the NUM_STREAM_THREADS_CONFIG = 1 in SmokeTestClient as we get locking issues when we have NUM_STREAM_THREADS_CONFIG > 1 and we have Standby Tasks, i.e., replicas. This is because the Standby Tasks can be assigned to the same KafkaStreams instance as the active task, hence the directory is locked Author: Damian Guy damian.guy@gmail.com Reviewers: Eno Thereska, Guozhang Wang Closes #1861 from dguy/fix-smoketest

hautel commented 6 years ago

Allow to continue to start the script even if there is a chown failure (#1917) When mounting a local folder with .git we have the following warnings chown: changing permission on ....git.idx : permission denied this new command allow to continue Change-Id: Idbedd1958e4a60a2aea251d1a657bbcdec063ffb Signed-off-by: Florent BENOIT fbenoit@codenvy.com

hautel commented 6 years ago

Don't log message for undefined EXIF rotation Summary: Currently, you will see Log.info entries TiffUtil: Unsupported orientation for each image with an undefined orientation - which is not true. Reviewed By: kirwan Differential Revision: D3819499 fbshipit-source-id: b0917cb77c32c639fc2e72e65f8e157811b56c2a