Implement IMDB ID extraction from movie/TV show title - Githubissues

havanagrawal / wikidata-toolkit

Bot for Wikidata to fix consistency and constraint issues on television series :tv:

MIT License

5 stars 8 forks source link

Implement IMDB ID extraction from movie/TV show title #8

Closed havanagrawal closed 3 years ago

havanagrawal commented 3 years ago

Problem

Implement the imdb_id function in external_identifier

Prerequisites

[ ] You know basic git, i.e. how to fork this repo, clone this repo, work on a branch and send a PR
[ ] You have basic working knowledge of Python
[ ] You are able to run Python on your machine
[ ] You are familiar with basic web scraping (example: requests, bs4 (BeautifulSoup), etc)

How to Test

Simply run python3 external_identifier.py and it will run doctests. Ensure that the test for imdb_id passes.

Hints

Try searching for some movie on www.imdb.com. What does the URL look like? You can use that to send a GET request.
Feel free to add more arguments (such as year) to the function if they help in increasing the confidence of the returned identifier.

mike-k0 commented 3 years ago

Taken a stab at this, see #13!

havanagrawal commented 3 years ago

Fixed by #13