havapa / testability-explorer

Automatically exported from code.google.com/p/testability-explorer
Apache License 2.0
0 stars 0 forks source link

Maven plugin should only uses classes directory and not entire runtime classpath #5

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. run the maven 2 plugin
2.
3.

What is the expected output? What do you see instead?

I expect the plugin will only run testability on the classes for a give
project not all of the dependencies of that project.  

Also, the plugin should have a better artifactId that identifies the plugin.

I have fixed these issues in the attached patch.

Original issue reported on code.google.com by jasoncha...@gmail.com on 27 Feb 2009 at 12:21

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for reporting this and especially for the patch. I'm leaving the 
artifactId,
since it makes sense with the groupId and matches the ant task. See
http://build.hevery.com/job/Testability-Explorer/259/changes#detail0

Original comment by aeagle22206 on 7 Mar 2009 at 12:02

GoogleCodeExporter commented 8 years ago
I understand the point that it makes sense in terms of the groupId, but I know 
that
you can specify some plugins without groupIds.  This may be only for
org.apache.maven.plugins....I cannot recall at this time.  If you can do it for 
any
groupId mapped in your settings.xml such as

  <pluginGroups>
    <pluginGroup>com.google.testability-explorer</pluginGroup>
  </pluginGroups>

then you might have a problem with this approach because then they would only 
need to
put the following the pom:

<plugin>
  <artifactId>maven2-plugin</artifactId>
</plugin> 

and that can be really confusing.  While I think this is always a bad way to 
define
plugins without groupIds, I see it all the time.

Original comment by jasoncha...@gmail.com on 7 Mar 2009 at 12:14

GoogleCodeExporter commented 8 years ago
Ah, I see, thank you for the explanation. I agree that it would suck if the 
groupId
wasn't always listed with the artifactId.

I submitted that change as
http://code.google.com/p/testability-explorer/source/detail?r=328

Thanks again for the help!!

Original comment by aeagle22206 on 18 Mar 2009 at 9:32