search

havard / node-openid

OpenID for Node.js
MIT License
293 stars 100 forks source link

TypeError: params.hasOwnProperty is not a function #148

Closed jtojnar closed 8 years ago

jtojnar commented 8 years ago

After upgrading to node 6.0.0, openid no longer works.

/home/jtojnar/projects/pengu/node_modules/openid/openid.js:1233
    if(params.hasOwnProperty(key) && key != 'openid.mode')
              ^

TypeError: params.hasOwnProperty is not a function
    at _checkSignatureUsingProvider (/home/jtojnar/projects/pengu/node_modules/openid/openid.js:1233:15)
    at _checkSignature (/home/jtojnar/projects/pengu/node_modules/openid/openid.js:1168:5)
    at _verifyAssertionAgainstProviders (/home/jtojnar/projects/pengu/node_modules/openid/openid.js:1132:12)
    at /home/jtojnar/projects/pengu/node_modules/openid/openid.js:1097:7
    at /home/jtojnar/projects/pengu/node_modules/openid/openid.js:546:7
    at /home/jtojnar/projects/pengu/node_modules/openid/openid.js:412:16
    at Request._callback (/home/jtojnar/projects/pengu/node_modules/openid/openid.js:175:7)
    at Request.self.callback (/home/jtojnar/projects/pengu/node_modules/request/request.js:200:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)

The params variable originates on line 908. It looks like querystring parser used by url.parse now uses a blank object.

artembykov commented 8 years ago

nodejs/node#6055

mscdex commented 8 years ago

PR for fix in #149.