search

havardgulldahl / jottalib

A library to access files stored at jottacloud.com.
GNU General Public License v3.0
83 stars 19 forks source link

Convert path operations using os.path.join() to "/".join() #39

Closed havardgulldahl closed 9 years ago

havardgulldahl commented 9 years ago

We need this for windows compability. Every invocation of os.path.join should be checked and if need be, changed.

Just like @thusoy did here: https://github.com/thusoy/jottalib/commit/2a8da24aa1ec73aff5d416803612a9b0ab14e9bd#diff-0d491925f77dc90df49511414dd9f158R140

It should be an easy job, and requires zero knowledge of the plumbing. So a great place to start for someone who wants to contribute.

mortenlj commented 9 years ago

Another way to do this, is to use posixpath instead of os.path, which gives you all the path-handling logic, while still giving you forward slashes regardless of platform.

havardgulldahl commented 9 years ago

Thanks for the suggestion!

havardgulldahl commented 9 years ago

@mortenlj Would you be able to take a stab at this bug?

mortenlj commented 9 years ago

I'll take a stab at it. Just so I don't misunderstand anything, this is about handling "Jotta-paths", which are essentially parts of an URL, correct?

havardgulldahl commented 9 years ago

Great! Yes, that's right.

søn. 30. aug. 2015 kl. 21.39 skrev Morten Lied Johansen < notifications@github.com>:

I'll take a stab at it. Just so I don't misunderstand anything, this is about handling "Jotta-paths", which are essentially parts of an URL, correct?

— Reply to this email directly or view it on GitHub https://github.com/havardgulldahl/jottalib/issues/39#issuecomment-136177585 .