This introduces a new escaping function for urls. Fixes #25

havardgulldahl / jottalib

A library to access files stored at jottacloud.com.

GNU General Public License v3.0

83 stars 19 forks source link

This introduces a new escaping function for urls. Fixes #25 #60

Closed ariselseng closed 8 years ago

ariselseng commented 9 years ago

Fixes https://github.com/havardgulldahl/jottalib/issues/57 and https://github.com/havardgulldahl/jottalib/issues/25.

havardgulldahl commented 8 years ago

Looks good, thank you for this.

I feel have the feeling that we need some tests, too. Do you have some suggestions to cover all corner cases?

havardgulldahl commented 8 years ago

Merged in b4397618fe5c7b80aa4acb8d49757115b375b1a0

Thank you for this!

ariselseng commented 8 years ago

Hi @havardgulldahl! Thanks for the merge :) I agree, we need some tests too for this. I will try to think about this and try to come up with some corner cases.