search

havardh / javaflow

Java model to flowtype converter
22 stars 5 forks source link

feat: throw ExitException instead of hard exit #55

Closed pascalgn closed 6 years ago

pascalgn commented 6 years ago

I replaced System.exit calls I found with throw new ExitException() so that it's easier to use this library in our code base :)

I also made some minor cleanups, if you want I can add them to another PR of course.

havardh commented 6 years ago

Great! Thank you :)

Could you re-word the commit message with the prefix feat? This project uses the angular (commit convention), and a refactor should not contain any functional changes. :+1: (this can be done with git commit --amend and requires a force push when you update the code).

I'd be happy to hear about how you plan to use it in your code base, and feel free to let me know if you find any other rough edges :)

pascalgn commented 6 years ago

I changed the commit message to feat: prefix! 👍

I was trying to use the library with our project, but mvn generate-sources kept exiting with error code 1, so I was a bit confused, that's where this PR is coming from :)

havardh commented 6 years ago

Great I'll see if I get time to test it and merge it this weekend :)

Are you using https://github.com/havardh/javaflow-maven-plugin to integrate it into your maven build?

pascalgn commented 6 years ago

Yes exactly, I'm using https://github.com/havardh/javaflow-maven-plugin!