search

havatv / qgisclimbplugin

QGIS Plugin to calculate the climb along a line
GNU General Public License v2.0
1 stars 0 forks source link

Core QGIS algorithm? #5

Open ghtmtt opened 5 years ago

ghtmtt commented 5 years ago

Hi @havatv I really really think that this plugin should go in core, of course if you agree.

Framework is easy, smooth and works super nice. What do you think about it?

havatv commented 5 years ago

Hi, @ghtmtt. No problem for me to have it in core. The more it can be used, the better.

ghtmtt commented 5 years ago

OK, could/should do you want to split the job in some ways? I can help if you want. Just tell me

havatv commented 5 years ago

What needs to be done? Is there a description of the procedure somewhere? And should this not be discussed more widely - there are not that many core plugins...

ghtmtt commented 5 years ago

actually you just need to take the algorithm.py and make some small tweaks. we can start to do that on a fork and then make a pull request

havatv commented 5 years ago

OK. You lead the way.

ghtmtt commented 5 years ago

Algorithm ready for PR: https://github.com/ghtmtt/QGIS/tree/processing_climb

I removed the calling to drape alg (we are in core so it is due to the user to do that). But an exception is raised and in the help file it is written.

I also added some tests.

So, I'll wait for your green light to click on the PR button.. and of course kudos to you, not to me :)

havatv commented 5 years ago

I have provided some comments and suggestions for your consideration.

lbell commented 5 years ago

Been playing around with this, and works great. I know this may buck against QGIS' standard work flow, but I'm really digging how the Calculate Geometry plugin works: Click a button or two, and the relevant layer fields are updated in place. Super-handy when geometries are changing frequently, and I need to keep recalculating the new state. (It's a bit arduous to create a new layer, save it as the old layer, etc...)