havatv / qgisnnjoinplugin

GNU General Public License v2.0
7 stars 8 forks source link

showError not defined in getwkbtext #22

Closed jott-al closed 5 years ago

jott-al commented 5 years ago

Hello,

For a vector layer of "PointZ" type a Python error ("name 'showError' is not defined") is generated. I was able to fix it by changing line 570 in NNJoin_gui.py (else: in getwkbtext) from showError(...) to _self._showError(...).

Would it make sense to include PointZ in the list of supported types, and issue a warning that the z coordinate will be ignored?

Joerg

havatv commented 5 years ago

Should be fixed with https://github.com/havatv/qgisnnjoinplugin/pull/23. Thanks, @jott-al!

havatv commented 5 years ago

More geometry types are supported with https://github.com/havatv/qgisnnjoinplugin/commit/976aa42455bf184179b294ac4aa77b8d1b21c443 The fixes are included in version 3.1.3 that is now uploaded on plugins.qgis.org.