haven-jeon / PyKoSpacing

Automatic Korean word spacing with Python

GNU General Public License v3.0

397 stars 118 forks source link

future version release? (Keras v3 support) #62

Closed m4a1carbin4 closed 3 months ago

m4a1carbin4 commented 3 months ago

It appears that TensorFlow has officially transitioned to Keras 3 as of version 2.16. However, it is uncertain whether the model for this project will function correctly in the TensorFlow Keras 3 backend environment.

I attempted to use this project with TensorFlow version 2.16, the official version that supports Python 3.12, because my personal project's Python environment is version 3.12. However, critical issues arise during the model loading process.

For this reason, I am curious if there are any future plans to ensure compatibility of this model with Keras 3.

haven-jeon commented 3 months ago

I acknowledge this as a critical issue and are actively looking into solutions.

A possible short-term workaround for the 2.15 version involves converting the existing binaries to the H5 format. I've completed the initial conversion step but haven't yet had a chance to fully test the performance impact.

If you're able to contribute a PR related to this workaround or any other potential fixes, it would be greatly appreciated.

m4a1carbin4 commented 3 months ago

63 Could you please review this PR? I Converted original model to TF SavedModel format (pb)

haven-jeon commented 3 months ago

I tested it and confirmed that it works well. Thank you so much for your work.

m4a1carbin4 commented 3 months ago

Thanks!