haven-protocol-org / haven-main

Haven is an untraceable cryptocurrency with a mix of standard market pricing and real world asset-pegged value storage. It achieves this via a “mint and burn” process within a single blockchain.
https://havenprotocol.org
Other
39 stars 25 forks source link

Cake Wallet adaptations to wallet2_api #67

Closed Tay8NWWFKpz9JT4NXU0w closed 1 month ago

Tay8NWWFKpz9JT4NXU0w commented 1 month ago

This pool request makes it possible to compile wallet2_api for Android, necessary for the integration with Cake Wallet. It combines a Monero rebase of wallet2_api and a switch to the new Oracle spot rates. Tests were done with this version and an Android version of Cake Wallet (latest version), and refresh and transfers seem to work. With some changes on Cake side, it is also possible to get the correct USD values using the spot Oracle rates.

Changes to wallet2.cpp were kept to a minimum.

Some things are still not perfect and will have to be fixed on Cake side (cannot be done by Haven):

Tay8NWWFKpz9JT4NXU0w commented 1 month ago

In addition, I would suggest to Cake to update their build process and bump the dependencies to the most recent stable versions in Fedora which still still work with Haven 4 (it is not a must that the same is done in the Haven build pipelines, but it might make sense eventually):

boost 1.83.0 (currently 1.72.0) unbound 1.20.0 (currently 1.16.2)

and similarly for iconv, openssl, sodium and zmq. Please let me know if you have any concerns about this approach. I will post an update for suggested versions of iconv, openssl, sodium, and zmq.

Tay8NWWFKpz9JT4NXU0w commented 1 month ago

Please disregard the last comment related to dependency upgrade, I will make a separate PR for it later on. It seems already making a switch to boost 1.83 is problematic, with issues related to compiling boost-locale, due to problems with finding a local libiconv during build, despite being present.