haveno-dex / haveno

Decentralized P2P exchange platform built on Monero and Tor
https://haveno.exchange
GNU Affero General Public License v3.0
928 stars 95 forks source link

Add IPv6 support #1076

Open shortwavesurfer2009 opened 1 week ago

shortwavesurfer2009 commented 1 week ago

Haveno does not recognize nodes on ipv6 such as feder8.me:18089 or [2607:3c40:1900:33e0::1]:18089

boldsuck commented 1 week ago

We discussed this topic in chat yesterday. Yes, IPv6 failed. Mainnet-nodes for testing: 2a0b:f4c2:2::63:18081, 2a0b:f4c2:2:1::223:18081, 2001:4ba0:ffff:c4::2:18081 Stagenet: 2605:6400:30:f91d::2:38081

woodser commented 3 days ago

Comment from @fa2a5qj3:

Seems monero-wallet-rpc/cli does not work through Tor proxy to an IPv6 destination (IPv4 is ok).

Prerequisites:

Tests:

  1. start monero-wallet-rpc connecting to IPv4 node (node3.monerodevs.org:18089)
  2. start monero-wallet-rpc connecting to IPv4 node (node3.monerodevs.org:18089) through SOCKS5 proxy
  3. start monero-wallet-rpc connecting to IPv6 node (feder8.me:18089)
  4. start monero-wallet-rpc connecting to IPv6 node (feder8.me:18089) through SOCKS5 proxy
  5. start monero-wallet-rpc connecting to IPv6 node ([2a0b:f4c2:2:63]:18081)
  6. start monero-wallet-rpc connecting to IPv6 node ([2a0b:f4c2:2:63]:18081) through SOCKS5 proxy

Tests 4 and 6 fail. I would have expected all 6 tests to pass. The error message is "no_connection_to_daemon".