haveno-dex / haveno

Decentralized P2P exchange platform built on Monero and Tor
https://haveno.exchange
GNU Affero General Public License v3.0
980 stars 109 forks source link

No Payout #1227

Open DaGoat518 opened 3 weeks ago

DaGoat518 commented 3 weeks ago

https://github.com/haveno-dex/haveno/issues/1187#issue-2440710654. Pertaining to this issue, I updated to lastest version, reopened dispute, and messaged arbitrator. The said they would try to release payout again. But dispute was closed and trade is still open and I haven't received payout.

woodser commented 3 weeks ago

Can you post or DM your latest logs related to processing the DisputeClosedMessage? That will give us a better idea of what it's doing.

DaGoat518 commented 3 weeks ago

I'm sorry, I'm not sure where to find logs.

Sent from Proton Mail Android

-------- Original Message -------- On 8/19/24 5:51 PM, woodser wrote:

Can you post or DM your latest logs related to processing the DisputeClosedMessage? That will give us a better idea of what it's doing.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 3 weeks ago

You can find your logs in haveno.log within your application folder:

DaGoat518 commented 3 weeks ago

Aug-20 09:40:08.105 [dpkWHQrO-20ae8688-d6e7-4910-9b3d-e7f599296f2e-108] WARN h.c.s.d.a.ArbitrationManager: Error processing dispute closed message: Failed to sign and publish dispute payout tx from arbitrator for BuyerAsTakerTrade dpkWHQrO-20ae8688-d6e7-4910-9b3d-e7f599296f2e-108: Not enough signers signed this transaction.

Sent with Proton Mail secure email.

On Tuesday, August 20th, 2024 at 9:38 AM, woodser @.***> wrote:

You can find your logs in haveno.log within your application folder:

  • Linux: ~/.local/share/Haveno/
  • macOS: ~/Library/Application Support/Haveno/
  • Windows: ~\AppData\Roaming\Haveno\

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 3 weeks ago

Is there an error stack trace, or multiple of them? Is it repeating the same error over and over again in your logs?

woodser commented 3 weeks ago

You can try applying this patch, which will correctly reject the arbitrator's last dispute decision when your error happens, so that you can open a new dispute and try again: https://github.com/haveno-dex/haveno/pull/1228

Here's the patch as a downloadable file:

pr_1228.patch

DaGoat518 commented 2 weeks ago

I hate to be a pain in the ass, but this is all new to me. I haven't a clue how to apply a patch. I'm beginning research on the process, but it seems there is quite a bit I need to learn, I'm just starting with the terminology. I really need to know this stuff anyway, but if you have any advice or recommendations on sources for info, I would appreciate it. A shortcut or a simple explanation how to approach this particular operation would be awesome, as I could really use payout. Thanks again I really do appreciate how helpful and responsive you have been.

Sent from Proton Mail Android

-------- Original Message -------- On 8/21/24 9:48 AM, woodser wrote:

You can try applying this patch, which will correctly reject the arbitrator's last dispute decision when your error happens, so that you can open a new dispute and try again: #1228

Here's the patch as a downloadable file:

pr_1228.patch

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 2 weeks ago

Sure no problem. Perhaps it's easiest to DM on matrix or email? Then we can walk through it step by step to test the fix, and we'll release the fix as part of the next release.

First build Haveno by following these instructions, but after installing the dependencies, replace the official GitHub URL in the instructions with the URL of the third party network you're using.

After building successfully, you can apply the fix by:

git remote add upstream https://github.com/haveno-dex/haveno.git
git fetch upstream
git pull --rebase upstream pull/1228/head
make skip-tests

Then launch Haveno with: make haveno-desktop-mainnet

Then the fix will be applied, so that it will reject the previous payout, and you can re-open the dispute to get the final payout.

Again, please feel free to DM for more direct communication.

DaGoat518 commented 5 days ago

So I need to build Haveno? What about what I already installed? It has my account and the trade that I need the payout on.

Sent from Proton Mail Android

-------- Original Message -------- On 8/28/24 1:35 PM, woodser wrote:

Sure no problem. Perhaps it's easiest to DM on matrix or email? Then we can walk through it step by step to test the fix, and we'll release the fix as part of the next release.

First build Haveno by following these instructions, but after installing the dependencies, replace the official GitHub URL in the instructions with the URL of the third party network you're using.

After building successfully, you can apply the fix by:

git remote add upstream https://github.com/haveno-dex/haveno.git git fetch upstream git pull --rebase upstream pull/1228/head make skip-tests

Then launch Haveno with: make haveno-desktop-mainnet

Then the fix will be applied, so that it will reject the previous payout, and you can re-open the dispute to get the final payout.

Again, please feel free to DM for more direct communication.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 5 days ago

The fix was incorporated in the last release, v1.0.11. Please update to the latest version. If your payout is still not complete, then you should be able to re-open the dispute.

DaGoat518 commented 5 days ago

I updated and initially trade was still open. Now trade is no longer open, no payout and xmr in reserve is gone.

Sent from Proton Mail Android

-------- Original Message -------- On 9/10/24 9:17 AM, woodser wrote:

The fix was incorporated in the last release, v1.0.11. Please update to the latest version. If your payout is still not complete, then you should be able to re-open the dispute.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 5 days ago

That would make sense if the payout was made. Can you confirm the payout state by going to Portfolio > History > select the trade > Info.

Is there a Payout transaction ID?

If you go to Detail Data, does it say Trade payout state: PAYOUT_UNLOCKED or something else?

DaGoat518 commented 5 days ago

Okay so I found trade in failed. Moved back to open, reserved is back but still no payout.

Sent from Proton Mail Android

-------- Original Message -------- On 9/10/24 9:53 AM, waltsgarden wrote:

I updated and initially trade was still open. Now trade is no longer open, no payout and xmr in reserve is gone.

Sent from Proton Mail Android

-------- Original Message -------- On 9/10/24 9:17 AM, woodser wrote:

The fix was incorporated in the last release, v1.0.11. Please update to the latest version. If your payout is still not complete, then you should be able to re-open the dispute.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 5 days ago

Ok, you should be able re-open the dispute to resolve the trade then.

DaGoat518 commented 5 days ago

There is now an orange link with an exclamation point that says trade is in an invalid state.

Sent from Proton Mail Android

-------- Original Message -------- On 9/10/24 9:53 AM, waltsgarden wrote:

I updated and initially trade was still open. Now trade is no longer open, no payout and xmr in reserve is gone.

Sent from Proton Mail Android

-------- Original Message -------- On 9/10/24 9:17 AM, woodser wrote:

The fix was incorporated in the last release, v1.0.11. Please update to the latest version. If your payout is still not complete, then you should be able to re-open the dispute.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 5 days ago

Yeah that's just because an error was associated with the trade. Feel free to copy and paste the error here (from within the trade's Info screen), but it should be fine to ignore.

DaGoat518 commented 4 days ago

Ok I reopened dispute, and messaged arbitrator letting them know that I updated to latest version.

Sent from Proton Mail Android

-------- Original Message -------- On 9/10/24 10:07 AM, woodser wrote:

Yeah that's just because an error was associated with the trade. Feel free to copy and paste the error here (from within the trade's Info screen), but it should be fine to ignore.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

@github.com>

woodser commented 4 days ago

Great. You should receive the payout when they resolve your dispute this time.

DaGoat518 commented 3 days ago

I still did not receive payout, and trade is still open with same error message.

Sent from Proton Mail Android

-------- Original Message -------- On 9/10/24 10:27 AM, woodser wrote:

Great. You should receive the payout when they resolve your dispute this time.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

woodser commented 2 days ago

It seems the wallet was corrupted somehow. This is the first case I've seen with this error, "Not enough signers".

The error would suggest either the multisig wallet wasn't initialized correctly, or one of your apps is not signing the dispute payout transaction correctly for some unknown reason.

In a worst case, you and the arbitrator may need to manually restore the multisig wallet by using monero-wallet-cli to import the wallet files, exchange updated info, and create the payout transaction.

In addition, I've added checks when the multisig is created to assert the expected state: https://github.com/haveno-dex/haveno/pull/1272

DaGoat518 commented 2 days ago

Okay, I'm now on simplex chat, and talking with tintedbrief, the arbitrator for dispute. Thanks again I really appreciate you guys and what you do!

Sent from Proton Mail Android

-------- Original Message -------- On 9/12/24 10:42 AM, woodser wrote:

It seems the wallet was corrupted somehow. This is the first case I've seen with this error, "Not enough signers".

The error would suggest either the multisig wallet wasn't initialized correctly, or one of your apps is not signing the dispute payout transaction correctly for some unknown reason.

In a worst case, you and the arbitrator may need to manually restore the multisig wallet by using monero-wallet-cli to import the wallet files, exchange updated info, and create the payout transaction.

In addition, I've added additional checks when the multisig is created to assert the expected state: #1272

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>