haveno-dex / haveno

Decentralized P2P exchange platform built on Monero and Tor
https://haveno.exchange
GNU Affero General Public License v3.0
1.04k stars 119 forks source link

support USDT-ERC20 and USDT-TRC20 #1388

Closed woodser closed 1 week ago

codacy-production[bot] commented 2 weeks ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.03% :white_check_mark: 54.55%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (6730d023d614fc0fcbda79b6846df24d325b6806) | 41403 | 4748 | 11.47% | | | Head commit (3b0e985cb89140de3ad9eea1703de92b667fd658) | 41422 (+19) | 4764 (+16) | 11.50% (**+0.03%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#1388) | 22 | 12 | **54.55%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

shortwavesurfer2009 commented 2 weeks ago

Wouldnt DAI be better since it cant be frozen? Obviously the USDC, USDT, etc backing of DAI could be frozen by those companies but to the best of my understanding DAI is unfreezable. With that said, I know they tried to rebrand to sky and launch a new contract that would allow freezing, but to my knowledge, the community rejected that.

woodser commented 2 weeks ago

DAI can potentially be supported in a future PR.

shortwavesurfer2009 commented 2 weeks ago

How will this show in the views? Personally i think Trocador has the right idea by doing coin (network). As an example "USDT (Ethereum)" or "USDC (Polygon)". That way you prevent yourself from using acronyms that some people might not understand such as "ERC20"

woodser commented 2 weeks ago

Currently it's using the display name "Tether USD (ERC20)".