haveno-dex / haveno

Decentralized P2P exchange platform built on Monero and Tor
https://haveno.exchange
GNU Affero General Public License v3.0
931 stars 96 forks source link

Haveno uses new obfs4proxy renamed lyrebird #927

Closed boldsuck closed 1 month ago

boldsuck commented 1 month ago

Background: The original obfs4proxy has ceased development, The Tor Project has forked it and renamed it to lyrebird.

Client side torrc configuration:

## obfs4proxy configuration
- ClientTransportPlugin obfs2,obfs3,obfs4,scramblesuit exec ./PluggableTransports/obfs4proxy
+ ClientTransportPlugin obfs4 exec ./PluggableTransports/lyrebird

gitlab.tpo Pluggable-Transports lyrebird Debian Bug#1063423

This is part of https://github.com/haveno-dex/haveno/issues/914#issue-2298237719 https://github.com/haveno-dex/netlayer

preland commented 1 month ago

Does this rename break the current obfs4 implementation in Haveno? What I am mainly looking at is this: https://github.com/haveno-dex/haveno/blob/master/p2p/src/main/java/haveno/network/p2p/network/DefaultPluggableTransports.java#L32

I'm just trying to understand whether the change needed is more on a logic level or on a cosmetic level "ie displayed strings"

boldsuck commented 1 month ago

No, nothing has changed on the bridgelines. Only the name of the binary has changed. Which is currently already in Haveno. Linux: ~/.local/share/Haveno/xmr_mainnet/tor/PluggableTransports/lyrebird

If I haven't overlooked anything, these are just these 3 config files that need to be changed: https://github.com/haveno-dex/netlayer/blob/master/tor.native/src/main/resources/native/linux/torrc.native https://github.com/haveno-dex/netlayer/blob/master/tor.native/src/main/resources/native/osx/torrc.native https://github.com/haveno-dex/netlayer/blob/master/tor.native/src/main/resources/native/windows/torrc.native

obfs2,obfs3,scramblesuit is vulnerable & not supported anymore.

preland commented 1 month ago

A PR is currently open on netlayer, which implements the fixes suggested here

woodser commented 1 month ago

I merged that PR, so the netlayer hash is ready to be updated in the haveno repo.

woodser commented 1 month ago

Hoping to include this in the next update @preland.

preland commented 1 month ago

On it

woodser commented 1 month ago

Fixed with https://github.com/haveno-dex/netlayer/pull/5 and https://github.com/haveno-dex/haveno/pull/955.