haveric / StackableItems

Minecraft Bukkit plugin that allows you to change the default stack size of items.
22 stars 17 forks source link

Jukebox Disc Dupe #178

Open Noobly-Walker opened 1 year ago

Noobly-Walker commented 1 year ago

Right-clicking a jukebox with a stack of music discs causes one to be removed from the player's inventory, but the whole stack to be placed into the jukebox's inventory. All but one then gets ejected, thereby duplicating almost the whole stack.

haveric commented 1 year ago

I haven't been able to replicate this. Can you provide some more information about your setup in order to help test this?

What server and version are you using? What version of StackableItems are you using? What is your items.yml setup within StackableItems?

Noobly-Walker commented 1 year ago

Server version: PaperMC 1.20.0-13 Plugin version: 1.2.0 Items.yml:


allWorlds:
  default: # Everything defined here will be applied to every player, group, inventory within every world UNLESS overridden below
    snow_ball: 64
    water_bucket: 16
    lava_bucket: 16
    milk_bucket: 16
    cod_bucket: 16
    salmon_bucket: 16
    pufferfish_bucket: 16
    tropical_fish_bucket: 16
    axolotl_bucket: 16
    tadpole_bucket: 16
    powder_snow_bucket: 16
    red_bed: 16
    orange_bed: 16
    yellow_bed: 16
    green_bed: 16
    cyan_bed: 16
    blue_bed: 16
    purple_bed: 16
    magenta_bed: 16
    white_bed: 16
    light_gray_bed: 16
    gray_bed: 16
    black_bed: 16
    pink_bed: 16
    brown_bed: 16
    lime_bed: 16
    light_blue_bed: 16
    potion: 16
    splash_potion: 16
    lingering_potion: 16
    cake: 16
    mushroom_stew: 16
    beetroot_soup: 16
    rabbit_stew: 16
    suspicious_stew: 16
    oak_boat: 16
    spruce_boat: 16
    birch_boat: 16
    jungle_boat: 16
    dark_oak_boat: 16
    acacia_boat: 16
    mangrove_boat: 16
    cherry_boat: 16
    bamboo_raft: 16
    oak_chest_boat: 16
    spruce_chest_boat: 16
    birch_chest_boat: 16
    jungle_chest_boat: 16
    dark_oak_chest_boat: 16
    acacia_chest_boat: 16
    mangrove_chest_boat: 16
    cherry_chest_boat: 16
    bamboo_chest_raft: 16
    minecart: 16
    hopper_minecart: 16
    chest_minecart: 16
    furnace_minecart: 16
    tnt_minecart: 16
    command_block_minecart: 16
    saddle: 8
    leather_horse_armor: 8
    iron_horse_armor: 8
    golden_horse_armor: 8
    diamond_horse_armor: 8
    enchanted_book: 8
    goat_horn: 8
    spyglass: 8
    decorated_pot: 16
    music_disc_13: 8
    music_disc_cat: 8
    music_disc_blocks: 8
    music_disc_chirp: 8
    music_disc_far: 8
    music_disc_mall: 8
    music_disc_mellohi: 8
    music_disc_stal: 8
    music_disc_strad: 8
    music_disc_ward: 8
    music_disc_11: 8
    music_disc_wait: 8
    music_disc_otherside: 8
    music_disc_5: 8
    music_disc_pigstep: 8
    music_disc_relic: 8
  inventory:
    chest,ender_chest,barrel,hopper,shulker_box,dispenser,dropper: #Overrides for containers
      ender_pearl: 64
      egg: 64
#      totem_of_undying: 16
#      wooden_sword: 8
#      stone_sword: 8
#      iron_sword: 8
#      gold_sword: 8
#      diamond_sword: 8
#      netherite_sword: 8
#      wooden_axe: 8
#      stone_axe: 8
#      iron_axe: 8
#      gold_axe: 8
#      diamond_axe: 8
#      netherite_axe: 8
#      wooden_pickaxe: 8
#      stone_pickaxe: 8
#      iron_pickaxe: 8
#      gold_pickaxe: 8
#      diamond_pickaxe: 8
#      netherite_pickaxe: 8
#      wooden_shovel: 8
#      stone_shovel: 8
#      iron_shovel: 8
#      gold_shovel: 8
#      diamond_shovel: 8
#      netherite_shovel: 8
#      wooden_hoe: 8
#      stone_hoe: 8
#      iron_hoe: 8
#      gold_hoe: 8
#      diamond_hoe: 8
#      netherite_hoe: 8
      leather_helmet: 8
      leather_chestplate: 8
      leather_leggings: 8
      leather_boots: 8
      chain_helmet: 8
      chian_chestplate: 8
      chain_leggings: 8
      chain_boots: 8
      iron_helmet: 8
      iron_chestplate: 8
      iron_leggings: 8
      golden_helmet: 8
      golden_chestplate: 8
      golden_leggings: 8
      golden_boots: 8
      diamond_helmet: 8
      diamond_chestplate: 8
      diamond_leggings: 8
      diamond_boots: 8
      netherite_helmet: 8
      netherite_chestplate: 8
      netherite_leggings: 8
      netherite_boots: 8
#      shield: 8
#      trident: 8
      turtle_helmet: 8
#      bow: 8
#      crossbow: 8
#      fishing_rod: 8
#      flint_and_steel: 8
#      shears: 8
#      brush: 8
      elytra: 8
#      carrot_on_a_stick: 8
#      warped_fungus_on_a_stick: 8
    brewing_stand: #Override for brewing stand
      potion: 1
      splash_potion: 1
      lingering_potion: 1
    crafting_table: #Override for crafting table
      bow: 16
    anvil:
      enchanted_book: 1
    jukebox: #Override for jukebox
      music_disc_13: 1
      music_disc_cat: 1
      music_disc_blocks: 1
      music_disc_chirp: 1
      music_disc_far: 1
      music_disc_mall: 1
      music_disc_mellohi: 1
      music_disc_stal: 1
      music_disc_strad: 1
      music_disc_ward: 1
      music_disc_11: 1
      music_disc_wait: 1
      music_disc_otherside: 1
      music_disc_5: 1
      music_disc_pigstep: 1
      music_disc_relic: 1
Noobly-Walker commented 1 year ago

I have, of course, commented out the music disc-related stack restrictions to prevent the dupe from being exploited. The same server, plugin version, and config also applies for every other issue I've posted, of course with all items not commented out.

haveric commented 10 months ago

I'm closing this as not being able to be reproduced. If you're still experiencing this issue, please re-open and let me know your current server info and settings, so I can dig into this some more.

Noobly-Walker commented 10 months ago

You need to have a stack of at least two music discs, and you need to rightclick the stack onto a jukebox, both to insert a disc, and extract one. My settings as follows: data/blastfurnaces.yml: default (blank) data/furnaces.yml: default (blank) data/smokers.yml: default (blank) lists/customfuel.txt: default (blank) furnaceXP.yml: default groups.yml: default (blank) items.yml: Discs were uncommented out and moved to default inventory. Discs stack to 8 in inventory slots or storage containers. options.yml: default

Noobly-Walker commented 10 months ago

Quoting someone on stack overflow: Github has very simple rights/privileges (and even simpler management for them).

If you are not a collaborator of a repo, then (in regards to issues)

That being said, I cannot reopen this issue. I would like it reopened, however, as this is still an issue I have.

Noobly-Walker commented 10 months ago

I made this gif demonstrating how I reproduce this issue. The gif is a quarter gigabyte, so I can't upload it directly, so here's a link to it. https://drive.google.com/file/d/18HlHBN2SfX6dbeRqK43pYpQj5-_zGZoC/view?usp=drive_link

haveric commented 10 months ago

Can confirm that this happens when using a paper server, but it does not happen on spigot. Not sure if there's a setting that would be affecting this, but it's a bit strange that paper is the cause.