the default-class is lost and overridden by local-class assignment.
For better customizability (especially application-wide settings) we should be able to combine CSS classes from settings with instance CSS classes (local markup etc.) to get both classes rendered default-class local-class.
Solution proposal
Some component libraries support this through additional syntax in CssClass-properties, such as +default-class, but this is probably not the way we would like to go.
Some of our component already use CoreCssClass properties/methods which behave this way (they get added to the CssClass in the end).
I think we should consolidate the current definitions and usages of [Xy]CoreCssClass and add the ability to set them through Settings and Defaults. This should solve the issue we are facing...
crdo
commented
2 years ago
Problem description
Currently, when you set
and then set the class in markup code
the
default-classis lost and overridden bylocal-classassignment.For better customizability (especially application-wide settings) we should be able to combine CSS classes from settings with instance CSS classes (local markup etc.) to get both classes rendered
default-class local-class.Solution proposal
Some component libraries support this through additional syntax in CssClass-properties, such as
+default-class, but this is probably not the way we would like to go.Some of our component already use
CoreCssClassproperties/methods which behave this way (they get added to theCssClassin the end).I think we should consolidate the current definitions and usages of
[Xy]CoreCssClassand add the ability to set them throughSettingsandDefaults. This should solve the issue we are facing...@crdo @jirikanda What do you think?