search

havit / Havit.Blazor

Free Bootstrap 5 components for ASP.NET Blazor + optional enterprise-level stack for Blazor development (gRPC code-first, layered architecture, localization, auth, ...)
https://havit.blazor.eu
MIT License
467 stars 64 forks source link

[HxGrid] Wrapping with TableContainer and HxProgressIndicator makes it difficult to style #465

Open crdo opened 1 year ago

crdo commented 1 year ago

It is one of my pain-points from G3 and BT2 but I am not sure if it is a good idea and it needs to be tested.

We wrap the HxGrid with two containers one for table-responsive that is reachable with TableContainerCssClass and one that comes from HxProgressIndicator, that is not reachable for CSS classes assignment at all. That makes it very difficult to style.

I suggest to merge these two lines (HxGrid 59 and 61) into one wrapper.

<HxProgressIndicator InProgress="@(InProgress ?? (dataProviderInProgress /* indicates data loading */ && !shouldRenderLoadingDataWithPlaceholders /* but not when placeholders are used - in such case we are indicating data loading using the placeholders */))">

    <div class="@CssClassHelper.Combine(ResponsiveEffective ? "table-responsive" : null, TableContainerCssClassEffective)">
hakenr commented 7 months ago

The HxProgressIndicator always renders <div class="hx-progress-overlay">. The proposed enhancement involves adding table-responsive and TableContainerCssClassEffective classes to this div.

Is this expected to be a minor breaking change, unlikely to significantly impact many users? @crdo, should I proceed?

hakenr commented 2 months ago

Implemented in 3b04c96130034888115f85b76cf95394fa5032fd and 85242dbba759de8c0afb89ecbb58f5ba5be73247. Pre-release 4.6.10-pre1 for testing.