havit / Havit.Blazor

Free Bootstrap 5 components for ASP.NET Blazor + optional enterprise-level stack for Blazor development (gRPC code-first, layered architecture, localization, auth, ...)
https://havit.blazor.eu
MIT License
472 stars 65 forks source link

[HxGrid] Multiselect with checkboxes demo is broken #858

Closed crdo closed 2 weeks ago

crdo commented 1 month ago

The checkbox state is out of sync with the rest of the demo https://localhost:5001/components/HxGrid#multiselect ScreenRecording2024-07-17at9 52 02-ezgif com-video-to-gif-converter

github-michl commented 1 month ago

For better navigation when solving a problem. https://github.com/havit/Havit.Blazor/blob/5c24c27b36ed30421ecba57956dcd53383457b17/Havit.Blazor.Components.Web.Bootstrap/Grids/HxGrid.razor#L146 returns GridCellTemplate but before OnParametersSet is executed in HxMultiSelectGridColumnInternal. So the status is displayed one change later. Maybe not having the SelectedDataItems in two instances, but just one current source of truth might help.

econner20 commented 4 weeks ago

Any updates on this issue?

econner20 commented 3 weeks ago

Issue still exists in latest build 4.6.12

StarGazer202424 commented 2 weeks ago

Issue still exists in latest build 4.6.12

I am also getting this issue in latest build.

@hakenr any update on this?

Also is there away to restore what are checked with persisting state?

hakenr commented 2 weeks ago

Publishing in 4.6.13-pre1 for testing. Any feedback is welcome, not just on this specific outcome but also on any other findings regarding the changes to the HxGrid implementation.

StarGazer202424 commented 2 weeks ago

Publishing in 4.6.13-pre1 for testing. Any feedback is welcome, not just on this specific outcome but also on any other findings regarding the changes to the HxGrid implementation.

I will play around with it. What else did you change?

hakenr commented 2 weeks ago

I will play around with it. What else did you change?

Just the internal implementation of the HxGrid, where the grid's rendering is now "deferred" in the rendering queue. It's a small change in terms of scope, but it might have unexpected effects on the behavior of HxGrid.

econner20 commented 2 weeks ago

This looks to have resolved the multiselect checkbox issue for me.

hakenr commented 2 weeks ago

@econner20 Thanks for confirmation.

StarGazer202424 commented 2 weeks ago

This looks to have resolved the multiselect checkbox issue for me.

Same here, I am working on an implementation of the grid will report back if I notice anything not working.

hakenr commented 2 weeks ago

@StarGazer202424 Thanks for confirmation.