Thing list (assistant page) is blowing up the app when there's a lot of things

[hawkbee1]

App try to load all the images which cause too much memory consumption.

1. impl

• [x] should get image file for the path from the domain repository image_repository network Info
• [x] should forward the call to DataConnectionChecker.hasConnection local data source
• [x] should return local image
• [x] should return remote image when ImageLocalDataSource.getImage return null
• [x] should return error "image not on device, need internet to try downloading from remote data source" when ImageLocalDataSource.getImage return null and device offline
• [x] should return error "Couldn't find image on device or remote data source" when local and remote failed

1. data sources
   • [x] should retrieve image from image folder in application document directory when it exists
   • [x] should have error "image not on device" when image does not exist
   • [x] Should retrieve image stored in firebase storage and store it in image folder
   • [x] Should have error "download/writing of remote image failed"
   • [x] should retrieve image from image folder in application document directory when it exists and path is remote
2. representation
   • [x] connect use case to image representation in assistant list
   • [ ] load only visible image
   • [ ] decrease memory size used by image displayed in the list

[hawkbee1]

app usecase : display filtered list of things in assistant/search screen list.view builder ? taking userSearchResultList as parameter which is a thing list (stuff in code until now)

[hawkbee1]

domain use case : get images of thing (thing) => for each path getImage(path) domain unit use case : get image (path) repository domain ? distant image or local image if local is here we get this one if local is not here 2 cases :

• get it from network and cache it if local storage disabled
• download it and store it locally if local storage enabled

[hawkbee1]

first : write first test for get image => should get image file for the path from the domain repository image_repository

[hawkbee1]

data layer : we don't need models and mappers since we just deal with files But we need to take care of choosing between local and Firebase data source

[hawkbee1]

we check path to know if it's a local path or a remote one

if local path we check if file is present, if file is present we return it

else we check connection
if device connected to internet we download file and store it locally
after storing file locally we change path of thing in thing list json file

we return file

[hawkbee1]

I already know I will lack some tests at end of this dev process :-1:

[hawkbee1]

no more app explosion but... I think something's fishy here

[hawkbee1]

adding test : local image repository : should extract filename from remote path

[hawkbee1]

switch on dev branch and ran debug mode : same pbm

[hawkbee1]

method = "StorageReference#writeToFile" this = {MethodChannel} arguments = {_InternalLinkedHashMap} size = 4 result = {_ByteDataView} TypedDataView(cid: 143)

[hawkbee1]

=> bucket and app value are null => some files should already be on local drive so the path has change during new version dev =>

[hawkbee1]

checking old local storage parameters : old version stored image at root of application document directory and new one is storing in image folder. checking activity to see if migration needed... I have regular users so I won't change folder without handling migration.

changing or not ?

• added value from having images stored in image folder : none except a better logic in the folder structure
• complexity to implement migration : 2 because i'm still no master in test implementation

verdict => keep images in root folder

changing image folder of tests to point directly on tdd/fixtures/image in image_local_data_source_test.dart updating code to have passing test changing image folder of tests to point directly on tdd/fixtures/image in test/tdd/data/datasources/image_remote_data_source_test.dart => good without change... tdd hurra !

[hawkbee1]

new bug : app is trying to download file with local storage path path

[hawkbee1]

error is presently not due to memory explosion as expected but 404 error inside firebase storage moduel when using writeToFile.... try catch doesn't work on this one... :-/ time to attempt a new package update in new branch

[hawkbee1]

can't catch firebase storage error, issue is dealt in firebase repository : https://github.com/FirebaseExtended/flutterfire/issues/792

[hawkbee1]

follow up in https://github.com/hawkbee1/where-assistant-public/issues/29 https://github.com/hawkbee1/where-assistant-public/issues/28