search

hawkerm / monaco-editor-uwp

A Windows Runtime Component wrapper around the web-based Monaco Editor.
MIT License
152 stars 36 forks source link

Update Monaco Uri class to use System.Uri or Windows.Foundation.Uri #33

Open hawkerm opened 4 years ago

hawkerm commented 4 years ago

Not sure which of the two .NET Uri classes makes more sense to use, but I think they both support the pieces needed to do a nice JsonConverter to make it easier to use the API in .NET.

hawkerm commented 4 years ago

We did use System.Uri already for the CssGlyphStyle here:

https://github.com/hawkerm/monaco-editor-uwp/blob/b390c5381b043f91fab9b0921729f37808b5b89c/MonacoEditorComponent/Monaco/Helpers/CssGlyphStyle.cs#L5

hawkerm commented 3 years ago

Not sure if there's other places, but for the Monaco Model Uri, there's a different problem, filed here #59.

hawkerm commented 3 years ago

Yeah, the Monaco Uri is special for a couple of things, so not sure if this makes sense in some spots. Need to think about this more.