Marker Text is duplicating

hawkerm / monaco-editor-uwp

A Windows Runtime Component wrapper around the web-based Monaco Editor.

MIT License

153 stars 36 forks source link

Marker Text is duplicating #62

Closed hawkerm closed 2 years ago

hawkerm commented 3 years ago

In Sample App (off of latest PR for #48), toggle the markers a couple of times:

The message text is getting duplicated and not cleaned up properly...

hawkerm commented 2 years ago

Ah, this was fixed by uncommenting the Editor.Markers.Clear() in #63. But I feel like the SetModelMarkersAsync call should have been doing the same thing, so there seems like there's a bug somewhere...

hawkerm commented 2 years ago

Clearing the Markers should just call the same SetModelMarkersAsync call in the ObservableVector callback, so no idea why that wasn't working. Going to try and remove the extra call and see if it still works...