Fix crashes in Release build

hawkerm / monaco-editor-uwp

A Windows Runtime Component wrapper around the web-based Monaco Editor.

MIT License

153 stars 36 forks source link

Closed hez2010 closed 2 years ago

hez2010 commented 3 years ago

Seems that it's a bug of .NET Native compiler. It failed to propagate JsonConverter from interface to implementation classes.

Also, I bumped some dependencies.

Fixes #60.

hez2010 commented 2 years ago

Any updates? It think this fix is simpler than putting lots of JsonIgnore.

hawkerm commented 2 years ago

Got busy at work last month, but want to get back to this soon. Just not sure how to approach reconciling the two PRs.

Would be a bit easier I think to have this based off of the existing changes in #48 and merge into that first instead.

The JsonIgnores are still useful as we don't need to be serializing those properties anyway.

hez2010 commented 2 years ago

The JsonConverter CssStyleConverter will ignore other properties automatically while doing serialization.

hawkerm commented 2 years ago

Rebased and merged this in to my prep branch. Thanks!