search

hawkerm / monaco-editor-uwp

A Windows Runtime Component wrapper around the web-based Monaco Editor.
MIT License
152 stars 36 forks source link

Use WebView2 #64

Open JaiganeshKumaran opened 3 years ago

JaiganeshKumaran commented 3 years ago

WebView 2 will be available to WinUI 2 soon so consider using that instead of EdgeHTML for better performance.

hawkerm commented 3 years ago

That's tied to #56 anyway as part of supporting WinUI 3.

JaiganeshKumaran commented 3 years ago

That's tied to #56 anyway as part of supporting WinUI 3.

Right however WinUI 2.8 itself is getting WebView2 so no need of WinUI 3.

hez2010 commented 3 years ago

Blocking issue: CoreWebView2.AddHostObjectToScript() results in AV in UWP.

hawkerm commented 3 years ago

@hez2010 is there an issue filed on the WinUI repo for that?

I also hit https://github.com/MicrosoftEdge/WebView2Feedback/issues/75 in general as well which could be challenging to work around, as I'd like new approach to be more direct with some of the Monaco provider objects.

hez2010 commented 3 years ago

@hez2010 is there an issue filed on the WinUI repo for that?

No, but I reused the issue https://github.com/microsoft/microsoft-ui-xaml/issues/4377.