Something weird is going on with update check/determination on Gen1 repository games

[instinctualjealousy]

Prerequisites

• [X] I've looked through existing issues to make sure that this bug hasn't been reported before.
• [X] I've read the GitHub Community Guidelines and know netiquette.

Playnite version

10.34.0.23368

Plugin version

1.0.4.32868

Comet version

0.1.2

Gogdl version

1.1.2

Bug description

Cleanly installed games for testing purposes. On every update check, it thinks these two games need updated when they don't.

https://www.gogdb.org/product/1207659238#builds https://www.gogdb.org/product/1207658976#builds

I'm thinking Gen1 games can't/don't provide a version number, unlike Gen2. Is this related to the issue?

Not sure if version getting filled with date is an intended behavior or just happens to be the next section of the parsed data being incorrectly used. It should be null/empty if not intended.

Update UI brainstorm- show build date alongside game title if version name doesn't exist, so it doesn't simply say the game name with no other details (as pictured).

Relevant log

  "1207659238": {
    "title": "Pandemonium 2",
    "platform": "windows",
    "executable": "",
    "install_path": "D:\\GOGLibrary\\Pandemonium 2",
    "version": "7/28/2015",
    "build_id": "48254350742780019",
    "installed_DLCs": [],
    "language": "",
    "is_fully_installed": false,
    "Dependencies": [
      "nGlide_103"
    ]
  },
  "1207658976": {
    "title": "Speed Busters",
    "platform": "windows",
    "executable": "",
    "install_path": "D:\\GOGLibrary\\Speed Busters",
    "version": "1/2/2015",
    "build_id": "3751",
    "installed_DLCs": [],
    "language": "",
    "is_fully_installed": false,
    "Dependencies": []
  }

Screenshots

[hawkeye116477]

I'm thinking Gen1 games can't/don't provide a version number, unlike Gen2. Is this related to the issue?

Some games might not provide version, but plugin isn't checking version number, but build id.

Please go to %APPDATA%\Playnite\ExtensionsData\03689811-3f33-4dfb-a121-2ee168fb9a5c\cache\infocache and show me manifest file with id in its name.

[instinctualjealousy]

Pandemonium 2: 1207659238.json 1207659238_build43977338.json 1207659238_build48254350742780019.json

Speed Busters: 1207658976_build26619746.json 1207658976_build50167263047686887.json 1207658976_build58012507054984672.json 1207658976.json 1207658976_build3751.json

The sheer amount might hint at something? I notice a couple are carrying the repo ID in their filenames.

[hawkeye116477]

~Build id seems same as in file with installed game, so should be rather fine. Are there any errors at log files?~

Update: Ah, I see the problem. Plugin takes buildId for checking, not build_id from build items array. Looks like those are different from some reason in case of G1.