hawkfalcon / Stardew-Mods

Stardew-Mods by hawkfalcon and ceruleandeep (Better Junimos, CustomQuestExpiration, & more)
MIT License
15 stars 33 forks source link

Extra buildeable zones fix-beta #59

Closed EienWolf closed 5 months ago

EienWolf commented 5 months ago

Reajusté algunas condiciones, búsquedas y filtros. Aún no lo he probado con todos los escenarios posibles, pero ya es compatible con Buildable Ginger Island Mod y Grampleton Mod. No lo probé, pero técnicamente debería funcionar con Build Anything Anywhere, siempre y cuando tengan tierra con la cual trabajar deberían hacerlo.

Faltan algunas correcciones de ruta de retorno y ver por qué no están entrando a los Greenhouse, pero ya lo veré otro día. Necesitaba hacer esta modificación para un servidor con amigos :3

resolves #58 resolves #34

=============================================================================

I have adjusted some conditions, searches, and filters. I haven't tested it with all possible scenarios yet, but it is already compatible with the Buildable Ginger Island Mod and Grampleton Mod. I haven't tested it, but it should technically work with the Build Anything Anywhere mod as long as there is soil to work with.

There are still some return path corrections needed, and I need to figure out why they are not entering the Greenhouse, but I will look into that another day. I needed to make this modification for a server with friends :3

hawkfalcon commented 5 months ago

Hey! Thank you for doing this. I'm a little worried some of these changes might break things, but as I have zero time I'll merge it and we can see if it works 🤩

Would you mind removing the commented out code & non-english comments (for consistency)? Thank you 🙂

EienWolf commented 5 months ago

This is in reference to the BetterJunimos/Utils/Util.cs file.

The fix is confined to this file. I have commented out the condition for getting "farms". All locations are buildable with mods, so only finding Junimo Huts is important.

Other changes are trash for this fix. So i fixed pull request tomorrow.

EienWolf commented 5 months ago

Pull request ready for merge

EienWolf commented 5 months ago

resolves #58 resolves #34