Pass prettier errors back to webpack on reject (solution for #37)

hawkins / prettier-webpack-plugin

Process your Webpack dependencies with Prettier

https://travis-ci.org/hawkins/prettier-webpack-plugin

50 stars 14 forks source link

Pass prettier errors back to webpack on reject (solution for #37) #38

Closed alesanchezr closed 6 years ago

alesanchezr commented 6 years ago

Added the callback call also on the Promise catch passing the error information.
caught the prettier errors to be able to reject the promise.

hawkins commented 6 years ago

Hey, thanks so much for the very detailed bug report and fix! This is awesome, and I'm really grateful to have this PR'd! 😄

If we could either remove that comment or help me understand it's significance if there is some then I'd love to merge this in. Thanks a million, and I'm glad you were able to find the fix and get back to it easily! 👍

scherroman commented 5 years ago

This is still an issue in the current version 1.2.0!

Version 1.2.0 was published on Oct 21, 2018 but it does not appear to include this fix. I love how this plugin integrates with webpack and goes to town on every save, but it keeps crashing my webpack --watch and webpack-dev-server every time there's a syntax error 😖

hawkins commented 5 years ago

@scherroman Sorry to hear that. If you can open a new issue with steps to reproduce it I'd be happy to see what I can do