hawknetwork / sealnote-plus

Android app for keeping encrypted notes
Other
1 stars 0 forks source link

Consider further changes to forked cardslib #51

Open ajburley opened 5 years ago

ajburley commented 5 years ago

Some changes were made to cardslib to make it build with the latest tools. However, some more changes were made in oplarshad/cardslib@ef39a99ef827802db488ad2203e742ca58053696 which have not been implemented in SealNote Plus. We need to look through those changes and see which of them are relevant to SealNote Plus.

ajburley commented 3 years ago

Note that many of the changes are actually to remove redundant code, which is a good thing, but not essential for this task of making it work with AAPT2.

Changes that only remove redundant code:

Changes that don't only remove redundant code:

ajburley commented 3 years ago

Note comment on #52 with the full list of changes made so far to cardslib.