search

hawknetwork / sealnote-plus

Android app for keeping encrypted notes
Other
1 stars 0 forks source link

Raise or map issues for TODO-style comments #61

Open ajburley opened 5 years ago

ajburley commented 5 years ago

There are a number of TODO or FIXME comments which were raised during legacy SealNote, or even during other projects which were later incorporated.

Each TODO or FIXME comment needs to be mapped to an open issue and listed in the top comment for that issue. If no issue currently exists for the item (probably the majority of cases) we need to raise one.

EDIT: In the legacy project there was also use of FIX (as opposed to FIXME); this will be changed to FIXME (#62) so we have some consistency. That's a dependency of this issue, so that we will have covered TODO, FIXME and FIX from the legacy codebases.

ajburley commented 5 years ago

Blocked by #62

ajburley commented 5 years ago

62 has been closed, so this can continue. There are 31 comments to process.

ajburley commented 5 years ago

Here are the numbers we will use to refer to the (code) comments in the remaining (issue) comments

  1. aFileChooser FileUtils - "handle non-primary volumes"
  2. aFileChooser FileUtils - "expose sorting option method"
  3. cardslib BaseDismissAnimation - "change"
  4. cardslib BaseCardOverlayAnimation - "more cards"
  5. cardslib SwipeDismissListViewTouchListener - "ensure this is a finger, and set a flag"
  6. cardslib SwipeDismissViewTouchListener - "ensure this is a finger, and set a flag"
  7. cardslib UndoCard - missing class-level documentation
  8. cardslib CardView - missing method-level documentation for getInternalContentLayout
  9. cardslib CardView - missing method-level documentation for getInternalInnerView
  10. layout activity_password - "hint is set in code for now"
  11. ColorDialogFragment - "this is not clean"
  12. StaggeredGridCard - "make it not dumb"
  13. StaggeredGridCard - "clean this s**t up"
  14. PasswordPreference - "set in XML"
  15. PasswordPreference - "what if password didn't change successfully"
  16. PreferenceHandler - "get integer"
  17. StaggeredGridAdapter - "check the implementation in array version of this adapter"
  18. TagEditText - "clean this up. mostly a hack"
  19. TagEditText - "hardcoded values, which itself doesn't work as expected. Probably density issue"
  20. NoteActivity - "take note object to make loading faster"
  21. NoteActivity - "do this asynchronously if required"
  22. NoteActivity - "only if id = -1"
  23. NoteActivity - "this can be made simpler maybe by making better layout"
  24. NoteActivity - "these bundles can be persistent and hence security hole"
  25. NoteActivity - "after timeout user should be able to continue from where they left off by giving password"
  26. NoteActivity - "crash when orientation is changed"
  27. NoteActivity - "hack. avoids double saving"
  28. NoteListActivity - "cleanup"
  29. NoteListActivity - switch(pos)
  30. PasswordActivity - "add progress bar"
  31. PasswordActivity - "toggle editable property of password textedit"