No support for http proxies

[alex-harvey-z3q]

I am in a large organisation and need to access the outside world using an HTTP proxy. Would you accept a pull request allowing optional configuration of the yumrepo's proxy attribute? https://docs.puppetlabs.com/references/latest/type.html#yumrepo-attribute-proxy

[alex-harvey-z3q]

Ping

[alex-harvey-z3q]

Ping

[hawknewton]

Wow, looks like your ping strategy worked out... I get too damn much email.

Yeah man, open a PR and we'll get it merged in.

[alex-harvey-z3q]

Thanks. :)

[alex-harvey-z3q]

Do I need to submit new unit tests to go with my change?

[hawknewton]

I'd like to maintain good test coverage when possible.

Open a PR, let's see where you're at.

[alex-harvey-z3q]

Well I'd like to do it properly - is how to run the tests documented somewhere?

[hawknewton]

https://github.com/hawknewton/puppet-pulp#developing

[hawknewton]

I just ran the specs for the first time in a year and it looks like I'm having an issue with establishing an ssl connection with the repo, I'll look into it.

bundle exec rake spec still works, though.

[alex-harvey-z3q]

I'm afraid I'm getting stalled by nokogiri on Mac hell:

alexs-mbp:puppet-pulp alexharvey$ bundle install
Fetching gem metadata from https://rubygems.org/...........
Resolving dependencies...
Using rake (10.1.1)
Installing CFPropertyList (2.3.0)
Using builder (3.2.2)
Using hitimes (1.2.2)
Using timers (4.0.1)
Using celluloid (0.16.0)
Using coderay (1.1.0)
Installing diff-lcs (1.2.5)
Installing excon (0.44.2)
Installing facter (1.7.6)
Installing ffi (1.9.6)
Using fission (0.5.0)
Using formatador (0.2.5)
Using mime-types (1.25.1)
Installing net-ssh (2.9.2)
Installing net-scp (1.2.1)
Installing fog-core (1.29.0)

Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.

    /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby extconf.rb --with-xml2-include=/usr/local/Cellar/libxml2/2.9.1/include/libxml2
checking for libxml/parser.h... yes
checking for libxslt/xslt.h... yes
checking for libexslt/exslt.h... yes
checking for iconv_open() in iconv.h... no
checking for iconv_open() in -liconv... yes
checking for xmlParseDoc() in -lxml2... no
-----
libxml2 is missing.  please visit http://nokogiri.org/tutorials/installing_nokogiri.html for help with installing dependencies.
-----
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
        --with-opt-dir
        --without-opt-dir
        --with-opt-include
        --without-opt-include=${opt-dir}/include
        --with-opt-lib
        --without-opt-lib=${opt-dir}/lib
        --with-make-prog
        --without-make-prog
        --srcdir=.
        --curdir
        --ruby=/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby
        --with-zlib-dir
        --without-zlib-dir
        --with-zlib-include
        --without-zlib-include=${zlib-dir}/include
        --with-zlib-lib
        --without-zlib-lib=${zlib-dir}/lib
        --with-iconv-dir
        --without-iconv-dir
        --with-iconv-include
        --without-iconv-include=${iconv-dir}/include
        --with-iconv-lib
        --without-iconv-lib=${iconv-dir}/lib
        --with-xml2-dir
        --without-xml2-dir
        --with-xml2-include=${xml2-dir}/include
        --with-xml2-lib
        --without-xml2-lib=${xml2-dir}/lib
        --with-xslt-dir
        --without-xslt-dir
        --with-xslt-include
        --without-xslt-include=${xslt-dir}/include
        --with-xslt-lib
        --without-xslt-lib=${xslt-dir}/lib
        --with-libxslt-config
        --without-libxslt-config
        --with-pkg-config
        --without-pkg-config
        --with-libxml-2.0-config
        --without-libxml-2.0-config
        --with-pkg-config
        --without-pkg-config
        --with-libiconv-config
        --without-libiconv-config
        --with-pkg-config
        --without-pkg-config
        --with-iconvlib
        --without-iconvlib
        --with-xml2lib
        --without-xml2lib

Gem files will remain installed in /Library/Ruby/Gems/2.0.0/gems/nokogiri-1.5.11 for inspection.
Results logged to /Library/Ruby/Gems/2.0.0/gems/nokogiri-1.5.11/ext/nokogiri/gem_make.out
An error occurred while installing nokogiri (1.5.11), and Bundler cannot continue.
Make sure that `gem install nokogiri -v '1.5.11'` succeeds before bundling.