search

hawkthorne / hawkthorne-journey

Digital Estate Planning: The Game
projecthawkthorne.com
1.09k stars 452 forks source link

Player still dropping through moving platforms #2483

Closed CalebJohn closed 9 years ago

CalebJohn commented 9 years ago

I think this is the second or third time I've fixed this bug, this time I'm fairly certain we've got it this time. Before this bug was fixed, but with the addition of some faster platforms in the recent village-forest upgrade this issue has come back, We now take the platforms dy value into consideration when placing the player on one so this should continue working even if we add faster platforms.

I also fixed a bug where if the player attempted to drop while on a moving platform and then jumped onto a one-way they would fall through as if they had dropped.

A good place to test either of these issues is village-forest.

niamu commented 9 years ago

Really liking the look of this change. Unfortunately, I'm useless testing this because I haven't been able to reproduce any of these bugs with my machine. Willing to merge for a release this weekend just on the basis of how the code looks though if we're ready for that. Depends on how much else we can fix.