search

hawkthorne / hawkthorne-journey

Digital Estate Planning: The Game
projecthawkthorne.com
1.08k stars 452 forks source link

Fix Tilda icon not appearing in inventory #2493

Closed CalebJohn closed 9 years ago

CalebJohn commented 9 years ago

Previously the icon would not appear in the inventory while doing Tilda's quests. The bulk of this change is just moving Tilda's dialogue into a npcs/quests/tildaquest.lua.

8bitgentleman commented 9 years ago

This is a solid change. Since you're in there this might be the time to restructure a little bit and address some of the confusion surrounding the quest.

niamu commented 9 years ago

:+1:

niamu commented 9 years ago

Perhaps we can also address this in the same way. http://www.reddit.com/r/hawkthorne/comments/3b75gf/glitch_when_removing_quest/

8bitgentleman commented 9 years ago

I've tried isolating those bugs and I think they have to do with the new quests not properly using the quest node and using dialog boxes instead.

CalebJohn commented 9 years ago

@8bitgentleman That's the same as what was happening here, the quests were being given without actually using the Quest module.

niamu commented 9 years ago

I stole @CalebJohn's work and integrated it with #2503. It started out as a small change to this code and then quickly spiralled out of control so the commits exist over there now as well.

CalebJohn commented 9 years ago

I'm going to close this in favor of #2503 we can re-open if needed.