hawkthorne / hawkthorne-journey

Digital Estate Planning: The Game
https://projecthawkthorne.com
1.1k stars 454 forks source link

Armor Inventory text is Unreadable #2596

Closed 8bitgentleman closed 3 days ago

8bitgentleman commented 4 days ago

I've been playing through the new web version of hawkthorne and in the valley town tried to buy armor but ran into this

image

I don't remember this bug, maybe it was introduced with the web version or the updated love2d?

niamu commented 4 days ago

Thanks for the report. I'll find time to investigate that in the next couple of days.

8bitgentleman commented 4 days ago

Same with armor text in the inventory it seems. Must be specific to the armor somehow image

niamu commented 4 days ago

Appears to be a web specific problem from my own testing so far. It looks fine for me when I test the game locally on macOS.

image
niamu commented 3 days ago

Ok, progress update: I have narrowed the problem to the TastyText library. We use that library to render the coloured text that appears in the stats section of the tooltip and for some reason the line count that it returns when in the browser is always 0 which is why the item info text is overlapped.

I just need to sort out why that problem is exclusively an issue on the web and develop a fix/workaround and we'll have this bug sorted.

niamu commented 3 days ago

PR up now with a fix. I have a couple other small love.js tweaks to make as well before pushing another release, but this bug is resolved.