hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Added license header formatting and checking in gradle #115

Closed sauravvishal8797 closed 7 years ago

sauravvishal8797 commented 7 years ago

fixed #114 Added license header formatting and checking in gradle.

KeenWarrior commented 7 years ago

@sauravvishal8797 You missed 3 things

KeenWarrior commented 7 years ago

Copyright 2015-${year} Red Hat, Inc. and/or its affiliates and other contributors as indicated by the @author tags.

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

KeenWarrior commented 7 years ago

@sauravvishal8797 Use this as header file

danielpassos commented 7 years ago

Can you please rebase this one from master?

KeenWarrior commented 7 years ago

@sauravvishal8797 Our current system is having finding HEADER file unrecog extension https://travis-ci.org/hawkular/hawkular-android-client/builds/209670767#L1129

What we can do for this is rename HEADER to HEADER.txt in all 3 locations

pilhuhn commented 7 years ago

The build still fails due to bad license. See https://travis-ci.org/hawkular/hawkular-android-client/builds/209679245#L1137

Please run (the Gradle equivalent) of mvn license:format on the files and also commit the ones that have changed.

KeenWarrior commented 7 years ago

thanks @sauravvishal8797