search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Disolving FavTriggersFragment into TriggersFragment #147

Closed KeenWarrior closed 7 years ago

KeenWarrior commented 7 years ago

I propose dissolving FavTriggersFragment into TriggersFragment. FavTriggersFragment and TriggersFragment have everything in common except at TriggersFragment data come from rest api at FavTriggersFragment data come from store.

m-murad commented 7 years ago

Can I work on this

pg301 commented 7 years ago

@garg-anuj I would like to work on it as well.

KeenWarrior commented 7 years ago

@free4murad Lets pick only one issue at a time. Please finish #144 for next issue.

KeenWarrior commented 7 years ago

@pg301 Go for it

pg301 commented 7 years ago

@garg-anuj Thanks 👍

pg301 commented 7 years ago

demo2 @garg-anuj I have replaced FavTriggerFragment but there is a small glitch now. Only when I refresh, this update comes. I have added the code in setUpForcedTrigger. Can you please guide me through.

pg301 commented 7 years ago

@garg-anuj I think I fixed it. I removed setupstate method from triggerFragment

KeenWarrior commented 7 years ago

@pg301 What you can do is place the PR with WIP (Work in progress) tag. So that we can help you out better