search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Show navigation drawer header dropdown only when there are multiple personas #164

Open janakamarasena opened 7 years ago

janakamarasena commented 7 years ago

screenshot_20170318-215915

Right now the drop down button next to the persona is always visible even though there is only one persona; this can mislead users. Shall we have the dropdown invisible by default and make it visible when there are items in list_personas?

Shall I do this and send a PR

m-murad commented 7 years ago

@janakamarasena I have a better idea. Why not an option to add account just like Gmail.

What do you think?

janakamarasena commented 7 years ago

@free4murad I think it is the intended plan going forward; need to think of proper UI layouts and more importantly how the app will work with multiple personas.

KeenWarrior commented 7 years ago

@janakamarasena @free4murad There was concept of multiple persona early on which have been removed as per for current.

It is presently not confirm if android client will continue to have multiple account or not.

janakamarasena commented 7 years ago

@garg-anuj shall I make the dropdown button invisible by default?

KeenWarrior commented 7 years ago

@janakamarasena Go on

m-murad commented 7 years ago

If the app will not support multiple accounts, Better is that you remove the button.

KeenWarrior commented 7 years ago

@janakamarasena @free4murad Ok. you guys leave it. I will remove whole persona stuff in few days :wink:

m-murad commented 7 years ago

@garg-anuj @danielpassos if @janakamarasena is not working on this, can I remove the files and code related to multiple persona.