search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Ripple effect missing. #168

Closed m-murad closed 7 years ago

m-murad commented 7 years ago

In AlertsFragment the list items are clickable but the ripple effect is missing. We should add the ripple effect to the list items.

I have solved this, should I send a PR?

pilhuhn commented 7 years ago

On 19 Mar 2017, at 19:56, Murad wrote:

In AlertsFragment the list items are clickable but the ripple effect is missing. We should add the ripple effect to the list items.

What is this ripple effect?

I have solved this, should I send a PR?

In cases you already have a patch, you can directly submit a PR and don't need to open an issue before.

m-murad commented 7 years ago

@pilhuhn This is a ripple effect. image

We are following this pattern in TriggersFragment

pilhuhn commented 7 years ago

On 19 Mar 2017, at 20:31, Murad wrote:

@pilhuhn This is a ripple effect. image

Ok, cool. Didn't know it is called that way.

-- hwr@pilhuhn.de m:0179/207 4919 b:http://pilhuhn.blogspot.com