search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Should not start fetching remote data before initial UI #179

Open KeenWarrior opened 7 years ago

KeenWarrior commented 7 years ago

This issue is currently in generic format and need to be further detailed

shubhamvashisht commented 7 years ago

I want to work in it.

shubhamvashisht commented 7 years ago

@garg-anuj can we break it into details?

KeenWarrior commented 7 years ago

@shubhamvashisht Approach I came up for this is. All aerogear pipe config and checking for auth should be moved after initial screen display. We can assume that auth state is same as last time app was visited.

shubhamvashisht commented 7 years ago

@garg-anuj as you mentioned the "initial screen display", is it about mainActivity before checking the auth status?

KeenWarrior commented 7 years ago

we can move auth status check and configure pipe to separate thread s it doesn't hamper UI. Additionally we may save auth state from last usage of app and assume state is same. Until we get to find out from other thread that there is some change.

shubhamvashisht commented 7 years ago

@garg-anuj great, can we break it into phases? i will start working on it.

KeenWarrior commented 7 years ago

@shubhamvashisht Move auth status check and configure pipe to separate thread as first mile stone

m-murad commented 7 years ago

@garg-anuj @shubhamvashisht @danielpassos I think this will change the LoginActivity.java file. If one is working on it, he should send the PR to @danielpassos branch.

(Just an opinion)