search

hawkular / hawkular-android-client

Apache License 2.0
10 stars 26 forks source link

Icons in exporer activity for Feed, Metrices etc have gone invisible #180

Open KeenWarrior opened 7 years ago

m-murad commented 7 years ago

Should I send a proof for this?

KeenWarrior commented 7 years ago

@free4murad You mean gif? Sure.

m-murad commented 7 years ago

Sorry I meant PR. Auto correct

KeenWarrior commented 7 years ago

@free4murad Two active issues are already under your belt. Let some issues to be enjoyed by others :wink:

anant-dev commented 7 years ago

@garg-anuj what icon ?? I am getting this screen screenshot_2017-03-21-22-42-28-073

KeenWarrior commented 7 years ago

https://github.com/hawkular/hawkular-android-client/blob/master/mobile/src/main/java/org/hawkular/client/android/explorer/InventoryExplorerActivity.java#L143

anant-dev commented 7 years ago

There is no icons in drawable with the title as in the code (operation_icon, resource_icon , etc) as you can see in https://github.com/hawkular/hawkular-android-client/tree/master/mobile/src/main/res/drawable

pg301 commented 7 years ago

@garg-anuj I would like to work on this one.

anant-dev commented 7 years ago

@garg-anuj @pg301 i have created a pull request for this issue

KeenWarrior commented 7 years ago

@pg301 Would you like to complete it?

pg301 commented 7 years ago

@garg-anuj Sure. I am on it 👍

m-murad commented 7 years ago

@garg-anuj @danielpassos @pilhuhn This is fixed and can be closed.